Skip to content
This repository has been archived by the owner on Dec 23, 2018. It is now read-only.

Random wallpapers #72

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Random wallpapers #72

wants to merge 2 commits into from

Conversation

Mysticle31
Copy link

Hello sdias or anyone who reads this :)

I've never used github before so this is my first time trying to contribute and contact someone. I've been messing with this all week.

I added a feature that will rotate desktop backgrounds based on a file of ./wallpapers/~Auto.jpg being chosen in settings.ini.

What it will do it when viewing a desktop with ~Auto.ini as the background it will choose a file at random from the /wallpapers directory, copy it as ~Auto.jpg then refresh the desktop background ~Auto.jpg.

I've checked it for bugs as thoroughly as I can and it works well except for one problem. If you switch from a desktop with with a solid color to an ~Auto.jpg desktop the file will be copied but the desktop will not refresh. It will remain old ~Auto.jpg. I have no idea why.

Any tips or hints as to the problem?

I'd love it if you would make the code better any way you can or even make it part of next release.

Instructions

  1. create wallpapers folder in script folder along with the others (docs, icons, libraries..etc)

  2. add wallpapers you would like to rotate between to wallpapers folder

  3. ADD to settings.ini in [Wallpapers] section ****

    AutoFileRefreshMinutes=

    a) Set the time interval in minutes you want to change the background
    b) Then just make any desktop you want automatically changed set to ~Auto.jpg

    For exmaple
    [Wallpapers]
    AutoFileRefreshMinutes=30
    1=~Auto.jpg
    End Example

Added Auto Rotating Backround based on timer.
@GioBonvi
Copy link
Collaborator

GioBonvi commented Jul 9, 2017

Hello @Mysticle31,
the feature you implemented looks really interesting: great work!

Before mergin it in, however, there are some things that should be fixed, at least regarding the formatting and style.

The first problem is related to newline characters: the source code uses Unix newline characters (\n), while your code uses Windows newline charcters (\r\n). This causes a lot of unnecessary noise in the diff of this PR.
From your comment it looks like you submitted the changes by uploading the file to GitHub through the web interface, which would explain this behaviour. Is this correct? Or did you use git (the command-line program) on your computer?

Secondly tabs should be replaced by 4 spaces to adapt to the existing source code styling.

Once these little problems are fixed we will be able to proceed with bugfixing and any other change that could be necessary.
If you need help in performing any of these steps you can ask for help commenting here.

Thank you for your great work again!

Best regards

@Mysticle31
Copy link
Author

I should have fixed the line breaks. The message boxes and line breaks were only there for me to diagnose what was happening. I since fixed that problem. I have thoroughly bug checked it now. I just uploaded the file from the web interface. I'm just starting the computer science/mis program and dont really know what I'm doing :)

I think I fixed the formatting too..

@GioBonvi GioBonvi changed the title Add files via upload Random wallpapers Jul 22, 2017
@sdias sdias removed the enhancement label Jan 31, 2018
@brunofin
Copy link

brunofin commented Apr 6, 2018

Hello! This is my first contact on this repo.

Could we get the conflicts resolved so we can merge this feature? I can see myself using this a lot :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants