WIP: Device trees fixups for 6.13 #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minlexx
force-pushed
the
qcom-sdm660-6.13.y-dt-fixes
branch
2 times, most recently
from
7f69945 to
77a4c08
Compare
Nokia 6.1 (nokia,pl2) is a smartphone based on SDM630 SoC. Signed-off-by: Alexey Minnekhanov <[email protected]>
Xiaomi Mi 8 Lite (xiaomi,platina) is a smartphone based on SDM660 SoC. Signed-off-by: Alexey Minnekhanov <[email protected]>
Asus Zenfone Max Pro M1 (asus,x00td) is a smartphone based on SDM636 SoC. Signed-off-by: Alexey Minnekhanov <[email protected]>
minlexx
force-pushed
the
qcom-sdm660-6.13.y-dt-fixes
branch
from
77a4c08 to
543bead
Compare
Xiaomi Redmi Note 6 Pro (xiaomi,tulip) is a smartphone based on SDM636 SoC. Signed-off-by: Alexey Minnekhanov <[email protected]>
minlexx
force-pushed
the
qcom-sdm660-6.13.y-dt-fixes
branch
from
543bead to
5828868
Compare
Xiaomi Mi A2 (xiaomi,jasmine) is a smartphone based on SDM660 SoC. Signed-off-by: Alexey Minnekhanov <[email protected]>
(not sure to which commit assign the fixups to, there was 2) Signed-off-by: Alexey Minnekhanov <[email protected]>
minlexx
force-pushed
the
qcom-sdm660-6.13.y-dt-fixes
branch
from
5828868 to
c3e0031
Compare
Xiaomi Mi Pad 4 (xiaomi,clover) is a 8-inch tablet based on SDA660 SoC. Xiaomi Mi Pad 4 Plus (xiaomi,clover-plus) is a 10-inch tablet based on SDM660 SoC. Signed-off-by: Alexey Minnekhanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream has some commits to our base
sdm630.dtsithat enable more things by default and do some things differently than we had before.We need to remove/fixup nodes with status=okay which are now enabled by default:
adsp_pil,anoc2_smmu,gpucc,kgsl_smmu, andlpass_smmuThere is new separate label for adreno zap firmware node:
adreno_gpu_zap. All GPU enablement should be done like in this commit: arm64: dts: qcom: sda660-ifc6560: enable GPU . In device DT separate enablement for adreno_gpu node and separate node for adreno_gpu_zap.For some/old dts also reorder nodes alphabetically and remove more unneed ones that are either already enabled or already disabled in parent .dtsi .
Fix several more dt-validate errors, like:
x.dtb: gpio-keys: 'vol_down', 'vol_up' do not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/input/gpio-keys.yaml#(buttons should start with e.gkey-*)gpio-hall-sensor: 'hall-sensor' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'node should be calledswitch?gpio-key,wakeup->wakeup-sourcex.dtb: extcon-usb: 'id-gpio' does not match any of the regexes: 'pinctrl-[0-9]+'(should beid-gpios)*-state, pin groups not ending with*-pinsfunction =in pins spec, but function is required (assumedfunction = "gpio")input-enableis not a thing in qcom TLMM - https://elixir.bootlin.com/linux/v6.13.1/source/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml#L78 . Change allinput-enabletooutput-disabletouchscreen-max-id,touchscreen-max-w,touchscreen-max-pproperties do not exist in any binding/driver.The list of DTs to fix, belonging to our fork (so excluding xperias and inforce board):
->sda660-xiaomi-clover.dtsFixes: #53