Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge all into main #298

Merged
merged 7 commits into from
Jun 22, 2024
Merged

Merge all into main #298

merged 7 commits into from
Jun 22, 2024

Conversation

fredclausen
Copy link
Member

This includes all of the open/recent PRs that we were holding off on. I think.

  • We need to test before merging. Build tag baseimage-test on all of the SDR-E stack containers. They'll auto build with this PR.
  • This includes wiede's cleaning script and updated version of S6 overlay
  • In addition, updated Debian base image

I'll test once the stack is built, but it would be nice to have someone else test too :)

fredclausen and others added 7 commits June 11, 2024 15:33
Bumps debian from bookworm-20240513-slim to bookworm-20240612-slim.

---
updated-dependencies:
- dependency-name: debian
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
* add build cleaning script

* apt: use autoremove that doesn't sometimes miss stuff
* Update Dockerfile.mlatclient

Updated instructions on how to use this baseimage

* Update Dockerfile.mlatclient

---------

Co-authored-by: Fred Clausen <[email protected]>
@fredclausen fredclausen requested a review from kx1t June 16, 2024 07:04
@fredclausen
Copy link
Member Author

@wiedehopf tagging you for visibility in case you have any comments.

@wiedehopf
Copy link
Contributor

wiedehopf commented Jun 16, 2024

So just as a comment, it would seem that the PR workflow triggred a rebuild of https://github.com/sdr-enthusiasts/docker-reversewebproxy/actions ?

That doesn't seem quite right.
Not that PRs here happen all the time but just in general.

Oh not of only reverseproxy but also a bunch of other containers.

@fredclausen
Copy link
Member Author

So just as a comment, it would seem that the PR workflow triggred a rebuild of https://github.com/sdr-enthusiasts/docker-reversewebproxy/actions ?

That doesn't seem quite right. Not that PRs here happen all the time but just in general.

Oh not of only reverseproxy but also a bunch of other containers.

That's actually intentional. I made that change when we updated to bookworm. It rebuilds them so we can test containers built against the new test base images, but it isn't pushing either the new base images or the other containers to latest. It uses baseimage-test

@fredclausen fredclausen merged commit baa16b8 into main Jun 22, 2024
36 checks passed
@fredclausen fredclausen deleted the merge-all-into-main branch June 22, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants