Fixed max_clusters bug #253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DataTransformer class allows you to initialize by setting max_clusters, but then when you fit this class o the data it uses the default value 10 at line 49, when it should use self._max_clusters.
Oufattole
requested review from
pvk-developer
and removed request for
a team
|
|
|
Hi @Oufattole, thanks for your interest in contributing to the SDV codebase. We are in the process of deprecating our old, CLA assistant bot (seen up above) and moving over to a new Contributor Licensing Agreement. To request our new Contributor Licensing Agreement, we ask that you please fill out the information in the form: https://bit.ly/sdv-cla-form. Once we receive your submission, we'll send you a PDF to the email that you give us. You will only have to complete this once for contributing to any of the libraries in the SDV ecosystem. Thanks for bearing with us! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DataTransformer class allows you to initialize by setting max_clusters, but then when you fit this class o the data it uses the default value 10 at line 49, when it should use self._max_clusters.