Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add py311 support #303

Merged
merged 12 commits into from
Jul 10, 2023
Merged

Add py311 support #303

merged 12 commits into from
Jul 10, 2023

Conversation

fealho
Copy link
Member

@fealho fealho commented Jul 6, 2023 •
edited
Loading

Resolve #296.

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (63cd6c9) 39.81% compared to head (ad511be) 39.81%.

❗ Current head ad511be differs from pull request most recent head 19b88d7. Consider uploading reports for the commit 19b88d7 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   39.81%   39.81%           
=======================================
  Files          10       10           
  Lines         751      751           
=======================================
  Hits          299      299           
  Misses        452      452

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fealho fealho changed the base branch from master to issue-302-remove-py37 July 7, 2023 04:20
@fealho fealho changed the base branch from issue-302-remove-py37 to master July 7, 2023 04:21
@fealho fealho changed the title Remove py37 and add py311 support Add py311 support Jul 7, 2023
@fealho fealho marked this pull request as ready for review July 7, 2023 15:24
@fealho fealho requested a review from a team as a code owner July 7, 2023 15:24
@fealho fealho requested review from pvk-developer and amontanez24 and removed request for a team July 7, 2023 15:24
amontanez24
amontanez24 reviewed Jul 7, 2023
View reviewed changes
setup.py Outdated
"scikit-learn>=1.1.3,<2;python_version>='3.10'",
"torch>=1.8.0;python_version<'3.10'",
"torch>=1.11.0;python_version>='3.10'",
"torch>=1.11.0;python_version=='3.10'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if the python version is 3.10.x? does it fall under this line or the next one?

Copy link
Member Author

@fealho fealho Jul 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some testing and I think 3.10.x == 3.10. We could put it as a range if we want to be extra sure though.

amontanez24
amontanez24 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good!

@fealho fealho force-pushed the issue-668-update-python-versions branch from 06ee2b8 to ad511be Compare July 8, 2023 04:03
@fealho fealho merged commit 186f2f0 into master Jul 10, 2023
@fealho fealho deleted the issue-668-update-python-versions branch July 10, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvk-developer pvk-developer pvk-developer approved these changes

@amontanez24 amontanez24 amontanez24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Python 3.11
4 participants
@fealho @codecov-commenter @amontanez24 @pvk-developer