Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff for linting, remove flake8, remove isort, remove pylint #389

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Jun 21, 2024

CU-86azg1bkw

@gsheni gsheni self-assigned this Jun 21, 2024
@gsheni gsheni requested a review from a team as a code owner June 21, 2024 20:48
@gsheni gsheni requested review from frances-h and removed request for a team June 21, 2024 20:48
@sdv-team
Copy link
Contributor

@gsheni gsheni requested a review from amontanez24 June 21, 2024 22:05
pyproject.toml Outdated
Comment on lines 191 to 192
"D105", # Missing docstring in magic method
"D107", # Missing docstring in __init__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will all other docstrings be enforced?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it so pydocstyle is ignored in the tests directory, but enforced elsewhere:
1b6a9fc

@gsheni gsheni requested a review from amontanez24 June 25, 2024 13:26
@gsheni gsheni merged commit d0679aa into main Jun 25, 2024
47 checks passed
@gsheni gsheni deleted the add_ruff branch June 25, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to using ruff for Python linting and code formatting
3 participants