In order to test new functionality (i.e. the read.commit.messages
function) new files containing test commit data were needed.
Add two files containing messages corresponding to the test commit data that
already exists.

See se-sic#180

Signed-off-by: Niklas Schneider <[email protected]>

Add the read.commit.messages and create.empty.commits.list functions
to util-read.R as well as a unit test to test the new functions.
This allows to read 'commitMessages.list' files and return the commit
data separated into message title and body.

See se-sic#180

Signed-off-by: Niklas Schneider <[email protected]>

Discussion has shown that codeface separates lines with five spaces, not four.
So the two test files have been modified to account for that fact.

See discussion in se-sic#180

Signed-off-by: Niklas Schneider <[email protected]>

Change the line breaks in the expected output to \n's.

See se-sic#180

Signed-off-by: Niklas Schneider <[email protected]>

Replace five spaces with \n, remove any white space at the beginning and
the end of a commit message.

See se-sic#180

Signed-off-by: Niklas Schneider <[email protected]>

Get the commit messsage data using the new read function and merge either nothing, the
title or message and title into the commit.data of the proj.conf instance.

See se-sic#180

Signed-off-by: Niklas Schneider <[email protected]>

Add the new attribute "commit.messages" to the project configuration class with options "none",
"title" and "message" to make it possible to specify what exactly of the commit message data
is to be merged to the commit data.

See se-sic#180

Signed-off-by: Niklas Schneider <[email protected]>

Signed-off-by: Niklas Schneider <[email protected]>

Add two tests for testing the merge functionality for both full commit messages and
titles only. Fix bug that merges message body instead of title when selecting
option "title"

See se-sic#180

Signed-off-by: Niklas Schneider <[email protected]>

Signed-off-by: Niklas Schneider <[email protected]>

Also exchange the merge attribute when merging data frames of commit
messages from commit.id to hash.

Signed-off-by: Niklas Schneider <[email protected]>

Signed-off-by: Niklas Schneider <[email protected]>

As commit.id was the first column of the data frame anyway,
merging has not changed the order. But when using the hash column
it is taken as the first colum of the resulting data frame.
Change the order of the columns in order to not break anything
that relies on the order.

See se-sic#180

Signed-off-by: Niklas Schneider <[email protected]>

Follow the review suggestions of @clhunsen.

See se-sic#180

Signed-off-by: Niklas Schneider <[email protected]>

Following the review of se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Remove some empty lines and indent some lines.
Also remove commit.message.data.unprocessed variable and use the
commit.message.data variable from the beginning. Add column names
beforehand in order to enable access without indices.

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Create private function update.commit.message.data in util-data.R
which handles the merge and change the location where it is
called in set.commits.

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Fix an error where the value of a variable that is defined
in an if block is returned outside that if block.

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Replaced a loop with a conversion from a list of vectors
in a data frame and access its columns directly

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Move functions concerning reading commit messages and the constants used
by them to a new section in util.read.
Replace subset with proper indexing and minor comment fixes.

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Also adapt 'update.commit.messages' to better match the implementation
of similar methods.
Add 'set.commit.messages' in order to be able to set the commit messages
to NULL.

See se-sic#193.

Signed-off-by: Niklas Schneider <[email protected]>

Introduce new function 'format.commit.ids' in along with new section in
util-read.R. Also put format "<commit-%s>" into a constant.

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Take advice by @clhunsen to replace if else cascade for rearranging columns with
better merge call.
Also modify test-data tests regarding commit messages: Row names are no longer
ignored.

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Change order in 'README.md', 'util-conf.R' and 'util-data.R'
Also fix table of contents in the readme.

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Add the package in 'install.R' and a description in the 'README.md'.
Also rearrange the parameter descriptions of 'ProjectConf' to be sorted
alphabetically.

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Use the new data.table package to replace do.call with data.table::rbindlist
which is faster in processing data.frames.

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Signed-off-by: Niklas Schneider <[email protected]>

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Remove hardcoded string formatting and replace it in tests for creating
expected data using the new function 'format.commit.ids'.

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Follow @clhunsen's advice to create commit message data with an
lapply to avoid having a for-loop and an additional lapply call
afterwards

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Add check for the ProjectConf attribute 'commit.messages' before
calling 'update.commit.messages'.
Also fix a few errors in comments as well as one if condition where
the wrong attribute was checked.

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Add the getter call to the 'additional.data' list.

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Add (empty) commit message data to all data split tests in 'tests-split.R'.
Also sor the additional data sources alphabetically in the tests.

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Add (empty) commit message data to all data split tests in
'test-split-sliding-window.R'.
Also sort the additional data sources alphabetically in the tests.

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

These functions act like cleanup.pasta, they remove rows from the data
that are not part of a range data object anymore.

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Fix a copy-paste-error where a varibale name was not changed from a
prior code snippet.

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Warn user when updating commit messages or synchronicity that they should
call the corresponding cleanup method.
Remove calls to unlist in those cleanup functions.
Fix copy-pasted comments.

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Fix the regex that removes spaces at the end of a commit message.
Change the assignment of the 'commit.message.data' data frame such that
no new data frame is instantiated anymore.

See se-sic#193

Signed-off-by: Niklas Schneider <[email protected]>

Our CI pipeline does currently not work for "R-3.3" (but for all the other
R versions in the pipeline). The reason for that is the following:
As of 2021-01-26, there is a new version of package `memoise` (2.0.0),
which is imported by `RSQLite`, which in turn is imported by `sqldf`.
The new version of `memoise` imports package `cachem`, which in turn
imports package `fastmap`. Using all these packages is not a problem per
se, they are compatible with R 3.3.3. However, the docker container
`r-base:3.3.3`, which we use in our pipeline "R-3.3", uses g++ version
6.3.0-9, which contains a bug. Due to the bug in the compiler, `fastmap`
cannot be compiled and installed in tje `r-base:3.3.3` docker container,
letting the CI pipeline fail.

To circumvent this problem but still keep "R-3.3" in our CI pipeline, we
now use docker image `r-base:3.3.2` instead, as there is another g++
version installed in this docker image. With that, the CI pipeline should
succeed for "R-3.3" again.

Signed-off-by: Thomas Bock <[email protected]>