Fix a bug in 'extract.timestamps' when dealing with an empty data source #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bockthom
reviewed
Oct 16, 2024
tests/test-data-cut.R
Outdated
|
|
||
| expect_identical(commit.data, commit.data.expected, info = "Cut Raw commit data.") | ||
| expect_identical(mail.data, mail.data.expected, info = "Cut mail data.") | ||
| expect_identical(issue.data, issue.data.expected, info = "Cut issue data.") |
There was a problem hiding this comment.
Maybe highlight that this is empty: "Cut issue data (empty)."
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #270 +/- ##
==========================================
+ Coverage 80.92% 80.95% +0.03%
==========================================
Files 16 16
Lines 5043 5051 +8
==========================================
+ Hits 4081 4089 +8
Misses 962 962 ☔ View full report in Codecov by Sentry. |
Up until now, `get.data.cut.to.same.date(data.sources =
c("issues", "mails", "commits"))` failed if some of the first data
source was empty, but not if the second one was empty. The reason was
that `NA` values introduced by empty data sources at the beginning of
the data frame turned the data frame into a data frame of numeric
objects instead of POSIXct objects. If there were already POSIXct
objects in the data frame, this did not happen. To prevent the
timestamps to be interpreted as numeric values, make sure that the `NA`
values are always POSIXct objects.
This fixes se-sic#269.
Signed-off-by: Thomas Bock <[email protected]>
This test fails without the previous fix by Thomas Bock but does not fail when the fix is in place. This works towards fixing se-sic#269. Signed-off-by: Maximilian Löffler <[email protected]>
Signed-off-by: Maximilian Löffler <[email protected]>
|
*The last force push was just because of rebasing |
That's what I have thought anyway 😄 |
bockthom
previously approved these changes
Oct 17, 2024
Signed-off-by: Maximilian Löffler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
showcase.Rwith respect to my changes.dev.Description
Include a fix by @bockthom for issue #269 and a new unit test for the previously faulty behavior.
Changelog
Fixed:
extract.timestampsthat occurs when the firstdata.sourceis empty and leads to a return value of typenumericwhich should bePOSIXct.