-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a suitable .ruby-version #229
Conversation
3c4b2fa
to
630e49c
Compare
What is the advantage of using |
Ah, I did not realise that a Gemfile could specify a Ruby version. In that case, it would be worth adding a Even so, the Gemfile |
Perhaps keep the new file and add |
I played around with this locally a bit and there is a catch: specifying the ruby version in the Gemfile makes it an error if a different version is used, which means the change would break current CI. I also got an error message for 2.7.8 -- it seems to not recognise itself ( It'd be possible, of course, (and maybe better) to specify the ruby version in CI manually and make sure that it is the one in .ruby-version, but that is a slightly larger change, and I still haven't figured out how to get around the self recognition error. I suspect we should upgrade ruby to a more recent version, make sure everything works well with that, and then specify it in the Gemfile as you suggest + update the build instructions. |
The doc site currently uses some old Jekyll plugins that only support Ruby version 2. The .ruby-version file works with `rvm` and `rbenv` to force the use of a suitable Ruby version. Version 2.7.8 is the last version of Ruby 2, which is now past end-of-life. Even for folks who don't use `rvm` or `rbenv`, the .ruby-version file is a useful indicator of which version of Ruby to use. Signed-off-by: Birgit Brecknell <[email protected]>
The doc site currently uses some old Jekyll plugins that only support Ruby version 2.
The .ruby-version file works with
rvm
andrbenv
to force the use of a suitable Ruby version. Version 2.7.8 is the last version of Ruby 2, which is now past end-of-life.Even for folks who don't use
rvm
orrbenv
, the .ruby-version file is a useful indicator of which version of Ruby to use.