libmicrokit: fix to successfully link on LLD #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should have an example that shows using LLVM tools to compile PD ELFs for both education reasons and as well as testing that it actually works. |
Ivan-Velickovic
force-pushed
the
libmicrokit_lld
branch
from
bd7789f to
e7a496c
Compare
LLD does not recognise the STARTUP directive which works with the GNU linker. Given that the crt0.s entry point is already specified to be at the start of the _text section when linking with libmicrokit, all we need to do is slightly change the Makefile to also include crt0.o when linking to produce libmicrokit.a Signed-off-by: Ivan Velickovic <[email protected]>
Previously the linker script referred to crt0.o which is why it was necessary that it was part of the SDK. However, now libmicrokit.a contains crt0.o and so it is not necessary to continue distributing crt0.o separately. Signed-off-by: Ivan Velickovic <[email protected]>
Ivan-Velickovic
force-pushed
the
libmicrokit_lld
branch
from
e7a496c to
651781c
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLD does not recognise the STARTUP directive which works with the GNU linker. Given that the crt0.s entry point is already specified to be at the start of the _text section when linking with libmicrokit, all we need to do is slightly change the Makefile to also include crt0.o when linking to produce libmicrokit.a