Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

Switch day buttons #23

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Switch day buttons #23

wants to merge 6 commits into from

Conversation

ianlofs
Copy link
Contributor

@ianlofs ianlofs commented May 13, 2016

This adds the ability to switch between days, weeks and months with some easy backwards and forwards buttons to control the data in the graph.

this.day = true;
break;
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that i can dedupe this, will follow up with a another PR.

@ianlofs
Copy link
Contributor Author

ianlofs commented May 13, 2016

realized that this is is not changing the granularity or the view window, only changing the interval of time that the left and right buttons move the graph, still only viewing a day at a time though. is that what was intended or if you click "month" should you see an entire months worth of data? @aadabi

@aadabi
Copy link
Member

aadabi commented May 13, 2016

Yeah entire month worth of data with 15 min granularity.

@ianlofs
Copy link
Contributor Author

ianlofs commented May 13, 2016

thats 2920 data points in the view window, seems like too many. normally we do it so the granularity matches 150 data points in the view window, then on zoom the granularity gets smaller

@aadabi
Copy link
Member

aadabi commented May 13, 2016

They have this in stock charts too, https://www.google.com/search?q=google+stock&rlz=1CDGOYI_enUS691US691&oq=google+stoc&aqs=chrome.1.69i57j0l3.13669j0j4&hl=en-US&sourceid=chrome-mobile&ie=UTF-8
You can reduce it to 1 hours So you have 1/4 points or 2 hours so you have 1/8 points

@ramhound
Copy link
Contributor

The date picker doesn't seem to be working correctly when selecting dates. Im getting inconsistent graphs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants