Use birpc #28
Merged
Use birpc #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanplee14
reviewed
Apr 4, 2024
|
|
||
| let rpcCallback: (data: any) => void | ||
| const rpc = createBirpc<SharedWorkerFunctions, TestWorkerFunctions>( |
There was a problem hiding this comment.
is the idea meant to establish a bidirectional communication with the postgres docker container?
There was a problem hiding this comment.
not quite
AVA's architecture has one worker thread per test file (called a test worker) and one worker thread per "shared worker" (called... a shared worker)
previous to this PR, we implemented 2-way RPC calls between the test worker and shared workers ourselves, but using birpc really makes the intent and logic cleaner
There was a problem hiding this comment.
oh i see, this is to communicate with ava's worker thread
ethanplee14
reviewed
Apr 4, 2024
| params: params as any, | ||
| connection: connectionDetails, | ||
| containerExec: async (command): Promise<ExecResult> => | ||
| rpc.execCommandInContainer(command), |
There was a problem hiding this comment.
you weren't kidding this is definitely way simpler
ethanplee14
approved these changes
Apr 4, 2024
phpnode
reviewed
Apr 4, 2024
panzerchris
approved these changes
Apr 5, 2024
|
Took me a while but this looks like a solid update! |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 5, 2024
# [7.2.0](v7.1.0...v7.2.0) (2024-04-05) ### Features * Merge pull request [#28](#28) from seamapi/feat-use-birpc ([ffcbb79](ffcbb79))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greatly simplifies code and paves the way for us to grab a new database instance within
beforeTemplateIsBaked()in application code.