Fix for workbook rels file paths and case #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workbook relationship target paths were being generated with relative paths including "xl/", Numbers and LibreOffice didn't like this. The sharedStrings target was all lower-case, they also didn't like this.
|
|
||
| def relative_path | ||
| "xl/worksheets/sheet#{ndx}.xml" | ||
| "xl/worksheets/#{filename}" |
There was a problem hiding this comment.
@spekode here you modify #relative_path, but in your changes to #workbook_rels you don't use it ... intentional?
There was a problem hiding this comment.
@seamusabshere absolute_path builds from relative_path, it seemed logical to build relative_path from filename.
| @@ -1,8 +1,8 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="yes"?> | |||
| <Relationships xmlns="http://schemas.openxmlformats.org/package/2006/relationships"> | |||
| <Relationship Id="rId0" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/sharedStrings" Target="sharedstrings.xml"/> | |||
There was a problem hiding this comment.
@seamusabshere re: #12 this is the only reference to "sharedstrings.xml" (all lower-case) that remains.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workbook relationship target paths were being generated with
relative paths including "xl/", Numbers and LibreOffice didn't like
this. The sharedStrings target was all lower-case, they also didn't like
this.