-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous updates #111
base: master
Are you sure you want to change the base?
Conversation
This just disallows older |
Thank you so much for the explanation, now I learned something new. I removed the dependency updates from the PR. |
Sorry for missing this 🙈 The dependency change is a good catch, we should stay conservative. Also, any changes that increase the MSRV should probably only be done because of a huge improvement. With such a basic, fundamental crate, we don't want to make it so people couldn't upgrade (even if they are using some ancient compiler). |
include
filed inCargo.toml
to reduce the crate size by 10%.libc
to latest version.hermit-abi
to latest version.Self
instead of structs name in theimpl
sMaybeUninit
instead ofmem::zeroed
. This removes anunsafe
block, but bumps MSRV to 1.36.0.Cgroup::new()
aconst
function, this bumps MSRV to 1.32.0.I understand that it's a lot of changes, and especially for those that increase the level, I'm ready to discuss its implementation and in case go back.
I tested this PR on Linux and Windows, using
cargo test --all-features --all-targets
,miri
andclippy
.