Skip to content

Commit

Permalink
Expand CI Matrix
Browse files Browse the repository at this point in the history
Support Rails 7.1 and 7.2. Experiment with Ruby 3.3.
  • Loading branch information
seanpdoyle committed Oct 24, 2024
1 parent 6a7bfb3 commit f5799e5
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 7 deletions.
13 changes: 11 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,19 @@ jobs:
- "2.7"
- "3.0"
- "3.1"
- "3.2"
- "3.3"
rails-version:
- "7.0"
- "6.1"
- "main"
- "7.0"
- "7.1"
- "7.2"
include:
- { ruby-version: "3.2", rails-version: "main" }
- { ruby-version: "3.3", rails-version: "main" }
exclude:
- { ruby-version: "2.7", rails-version: "7.2" }
- { ruby-version: "3.0", rails-version: "7.2" }

env:
RAILS_VERSION: ${{ matrix.rails-version }}
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- Expand matrix of supported versions to include `[email protected]` and `[email protected]`.

## 0.2.2 (Jan 12, 2023)

- Qualify call to `render "turbo_stream_button_tag"` with `application/`
Expand Down
4 changes: 2 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ gemspec
# Start debugger with binding.b [https://github.com/ruby/debug]
# gem "debug", ">= 1.0.0"

rails_version = ENV.fetch("RAILS_VERSION", "7.0")
rails_version = ENV.fetch("RAILS_VERSION", "7.2")

rails_constraint = if rails_version == "main"
{github: "rails/rails"}
Expand All @@ -32,7 +32,7 @@ group :test do
github: "thoughtbot/action_dispatch-testing-integration-capybara", tag: "v0.1.0",
require: "action_dispatch/testing/integration/capybara/minitest"
gem "capybara"
gem "capybara_accessible_selectors", github: "citizensadvice/capybara_accessible_selectors", branch: "main"
gem "capybara_accessible_selectors", github: "citizensadvice/capybara_accessible_selectors", tag: "v0.10.0"
gem "selenium-webdriver"
gem "webdrivers"
end
6 changes: 3 additions & 3 deletions test/integration/examples_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class ExamplesTest < ActionDispatch::IntegrationTest
<% end %>
ERB

assert_equal ["Only once"], response.body.scan(/Only once/)
assert_equal ["Only once"], response.body.scan("Only once")
end

test "merges [data-controller] attribute" do
Expand Down Expand Up @@ -74,7 +74,7 @@ class ExamplesTest < ActionDispatch::IntegrationTest
assert_equal "click->turbo-stream-button#evaluate click->my-controller#action", button["data-action"]
end
assert_css(%(template[data-turbo-stream-button-target~="turboStreams"]), visible: :all)
assert_equal ["A turbo stream"], response.body.scan(/A turbo stream/)
assert_equal ["A turbo stream"], response.body.scan("A turbo stream")
end

test "turbo_stream_button merges into other helpers" do
Expand All @@ -95,6 +95,6 @@ class ExamplesTest < ActionDispatch::IntegrationTest
assert_equal "click->turbo-stream-button#evaluate", button["data-action"]
end
assert_css(%(template[id="a-template"][data-turbo-stream-button-target~="turboStreams"]), visible: :all)
assert_equal ["A turbo stream"], response.body.scan(/A turbo stream/)
assert_equal ["A turbo stream"], response.body.scan("A turbo stream")
end
end

0 comments on commit f5799e5

Please sign in to comment.