Use declare readonly to avoid overriding the existing Stimulus property
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinzonjulian
changed the title
declare keyword avoids to avoid overriding the existing Stimulus propertydeclare readonly to avoid overriding the existing Stimulus property
|
@pinzonjulian thank you for opening this PR. I'm sorry that it has sat unacknowledged for as long as it has. I've restored CI to a passing state. Could you rebase this branch off of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change follows the advice from the Stimulus reference to make sure the property that stimulus creates is not overwritten.
I found this to be an issue when I encountered the following error:
This was working just fine before but became an issue after we started upgrading some packages in our company. I haven't been able to pinpoint exactly what caused the issue though. I should also note, I'm not using this gem or package directly, I just copied the controller to our codebase but thought I opened this PR to help out.