Simplify HTML attribute token list merging #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rely on view context's `#token_list` to merge token lists. Manipulating the token list manually (through calls to `String#split` and `Array#join`) had the potential to affect `ActiveSupport::SafeBuffer` HTML safety. This commit replaces that bespoke logic with calls to [ActionView::Helpers::TagHelper#token_list][] to rely entirely on the view for managing the escaping, safety, and joining of the String values. []: https://edgeapi.rubyonrails.org/classes/ActionView/Helpers/TagHelper.html#method-i-token_list
seanpdoyle
force-pushed
the
use-view-to-merge-token-lists
branch
from
56e9a9d to
fa95dd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rely on view context's
#token_listto merge token lists.Manipulating the token list manually (through calls to
String#splitandArray#join) had the potential to affectActiveSupport::SafeBufferHTML safety.This commit replaces that bespoke logic with calls to ActionView::Helpers::TagHelper#token_list to rely entirely on the view for managing the escaping, safety, and joining of the String values.