Skip to content
This repository was archived by the owner on Jun 10, 2020. It is now read-only.

Added accessibility tags into control and removed nested containing div #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jackleberry
Copy link

@Jackleberry Jackleberry commented Oct 25, 2017

Added the following tags to the outer div for accessibility:

role="feed"
aria-setsize="-1"
aria-busy={this.state.isInfiniteLoading}

Remove the nested div (smoothScrollingWrapper) and moved infiniteScrollStyles to the outer div.

Fixed lint errors and tests.

@Jackleberry
Copy link
Author

@garetht Would you be interested in merging this PR into the main codebase?

@garetht
Copy link
Contributor

garetht commented Nov 3, 2017

@Jackleberry sorry for the delay! This will be a breaking change that is incompatible with older versions so it will have to wait for an explicitly incompatible release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants