Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Doctrine\DBAL\Exception import, replace with \Throwable. #661

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

herpaderpaldent
Copy link
Contributor

No description provided.

Copy link

what-the-diff bot commented Jan 4, 2025

PR Summary

  • Dependency on Doctrine DBAL Removed
    We have removed the usage of the existing "doctrine/dbal": "^3.0" package from our treasure chest, me hearties. This makes our application less dependent on third-party packages and thus leaner and more self-sufficient.

  • Updated Exception Type
    In the MigrateDb.php parchment, we've replaced the old exception type with the \Throwable type. This new exception type is more inclusive, able to catch more types of problems that might occur. We've also swept away the import statement for Doctrine\DBAL\Exception as it's no longer needed aboard our ship. This makes our error handling more efficient and flexible, ready to weather any storm.

@herpaderpaldent herpaderpaldent merged commit e2b3837 into 4.x Jan 4, 2025
2 checks passed
@herpaderpaldent herpaderpaldent deleted the refactor/dbal branch January 4, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant