Add Vlasky's content

[noah-severyn]

This PR adds all of Vlasky's content. Ref #99.

[sebamarynissen]

Personally I tend to use the author's name for the group name as much as possible. It's a bit arbitrary, and I feel like maybe we should establish a clear convention on this. Any suggestions?

[noah-severyn]

You know what, I think you're right. I was previously wanting to prefer the team whenever possible, but it does feel a little more natural to say "Vlasky's NYBT 525 west 48th street" than "NYBT's 525 west 48th street (by Vlasky)". The team is usually always the first part of the name anyways, so it'll be easy to search for. I'll update this.

[sebamarynissen]

It looks like the author is not completely inactive (last visit was in April 2024), so maybe I would anticipate on a potential future fix by using a regex here: /Industrial Revolution Mod_Zoning/Qua?druple lot/

[noah-severyn]

I wouldn't necessarily anticipate a fix (if there hasn't been one since 2012), but a regex is not a bad idea anyways.

[sebamarynissen]

General remark: if you want to automatically strip the NYBT prefix from the package names - which I recommend - then you can add the author to permissions.yaml and add nybt to the prefixes. In this case, this would mean:

- id: 237489
  name: Vlasky
  prefixes:
    - nybt

[noah-severyn]

General remark: if you want to automatically strip the NYBT prefix from the package names - which I recommend - then you can add the author to permissions.yaml and add nybt to the prefixes.

Why would this be something you recommend?

[sebamarynissen]

Why would this be something you recommend?

Basically because in the default channel it is often omitted too. In the default channel, the "rule" seems to be that non-dependency plugins don't include the team name, whereas dependencies do include the team name as the group field. As @memo33 already said though, it's a bit arbitrary and with the advent of the gui and the ST integration, the exact package name becomes less important anyway, but I'd say that consistency becomes more important now (for example packages from the ST channel being "promoted" to the default channel ideally keep their name).

[noah-severyn]

Basically because in the default channel it is often omitted too. In the default channel, the "rule" seems to be that non-dependency plugins don't include the team name, whereas dependencies do include the team name as the group field. As @memo33 already said though, it's a bit arbitrary and with the advent of the gui and the ST integration, the exact package name becomes less important anyway, but I'd say that consistency becomes more important now (for example packages from the ST channel being "promoted" to the default channel ideally keep their name).

Thank you for the extra explanation; that makes sense. I'll update this PR and proceed this way in the future. I'll also update the permissions with the rest of the NYBT members.

[memo33]

Over the last 10 years or so, publishing under team names has become less common, as most of the teams disbanded. So if the content is clearly attributable to a single author who ideally is also the uploader, I think it makes sense to use the author name as group. For dependency packs, I mainly followed existing names to make it easy to identify and recognize the correct dependency pack.