Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata: add Jasoncw's content #54

Merged
merged 26 commits into from
Dec 31, 2024
Merged

metadata: add Jasoncw's content #54

merged 26 commits into from
Dec 31, 2024

Conversation

sebamarynissen
Copy link
Owner

This PR adds almost all of Jasoncw's content.

image

image

@memo33 I've noticed that when switching between MN and DN after plopping the lots, suddenly some brown boxes appear. I've verified, and it's because for some lots, different TGI's are used for the MN and DN models. What would you advice in such cases? It's not really a problem of .sc4pac of course, but it is aggravated because sc4pac allows switching between MN and DN in the blink of an eye. I was thinking that perhaps for the affected packages, I should keep both DN and MN models, regardless of the variant in use.

@memo33
Copy link

memo33 commented Dec 31, 2024 via email

@sebamarynissen
Copy link
Owner Author

Alright, away with it then.

Could you have a quick look at memo33/sc4pac#61? Then I can merge this.

@memo33
Copy link

memo33 commented Dec 31, 2024

Done.

@sebamarynissen sebamarynissen merged commit 3975bd6 into main Dec 31, 2024
2 checks passed
@sebamarynissen sebamarynissen deleted the feature/jasoncw branch December 31, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants