-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metadata: add Jasoncw's content #54
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switching between MN and DN in an already developed city is not even a feature that is meant to work. The same applies to almost all other variants that aren't purely FSHs. I disagree about keeping both models as the chances of that being of any use are near zero. Even if you kept both models, the built lots would still reference the old TGIs I think, at least for props.
|
Alright, away with it then. Could you have a quick look at memo33/sc4pac#61? Then I can merge this. |
Done. |
This reverts commit d76febc.
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds almost all of Jasoncw's content.
@memo33 I've noticed that when switching between MN and DN after plopping the lots, suddenly some brown boxes appear. I've verified, and it's because for some lots, different TGI's are used for the MN and DN models. What would you advice in such cases? It's not really a problem of .sc4pac of course, but it is aggravated because sc4pac allows switching between MN and DN in the blink of an eye. I was thinking that perhaps for the affected packages, I should keep both DN and MN models, regardless of the variant in use.