Fix "Uninitialized string offset -1" warning

sebastianbergmann · Oct 30, 2024 · 2c3940e · 2c3940e
1 parent df95a6e
commit 2c3940e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/src/ScalarComparator.php b/src/ScalarComparator.php
@@ -133,6 +133,10 @@ private static function removeOverlongCommonSuffix(string $string1, string $stri
 
     private static function findCommonSuffix(string $string1, string $string2): string
     {
+        if ($string1 === '' || $string2 === '') {
+            return '';
+        }
+
         $lastCharIndex1 = strlen($string1) - 1;
         $lastCharIndex2 = strlen($string2) - 1;
 

diff --git a/tests/unit/ScalarComparatorTest.php b/tests/unit/ScalarComparatorTest.php
@@ -145,6 +145,17 @@ public static function assertEqualsFailsWithDiffProvider(): array
 --- Expected
 +++ Actual
 @@ @@
+-''
++'other string'
+",
+                '',
+                'other string',
+            ],
+            [
+                "
+--- Expected
++++ Actual
+@@ @@
 -'...string which will be cut HERE some trailer'
 +'...string which will be cut XYZ some trailer'
 ",