Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid serialization of cache data in PHP report #1011

Merged

Conversation

Slamdunk
Copy link
Contributor

Fix #1009

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #1011 (22c0d82) into 9.2 (78ba572) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                9.2    #1011      +/-   ##
============================================
+ Coverage     83.98%   84.00%   +0.01%     
- Complexity     1193     1194       +1     
============================================
  Files            61       61              
  Lines          4272     4275       +3     
============================================
+ Hits           3588     3591       +3     
  Misses          684      684              
Files Changed Coverage Δ
src/CodeCoverage.php 50.36% <100.00%> (+0.36%) ⬆️
src/Report/PHP.php 90.00% <100.00%> (+1.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Slamdunk
Copy link
Contributor Author

This PR should be easily mergeable into upstream branch main, so no need for a separate PR as far as I can tell

@sebastianbergmann sebastianbergmann merged commit 2c9ee25 into sebastianbergmann:9.2 Sep 12, 2023
@Slamdunk Slamdunk deleted the cc_php_report_without_cache branch September 13, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants