Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phpstan-type declarations #1051

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Dec 9, 2024

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.80%. Comparing base (48b98da) to head (fc41dd1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1051   +/-   ##
=========================================
  Coverage     85.80%   85.80%           
  Complexity     1360     1360           
=========================================
  Files            90       90           
  Lines          4671     4671           
=========================================
  Hits           4008     4008           
  Misses          663      663           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

the syntax does not have a `=`
@staabm
Copy link
Contributor Author

staabm commented Dec 9, 2024

now tested locally. it does not fix the issue, but still is a required change IMO

@staabm staabm marked this pull request as ready for review December 9, 2024 08:59
@sebastianbergmann sebastianbergmann merged commit ad9fcff into sebastianbergmann:main Dec 9, 2024
16 checks passed
@sebastianbergmann
Copy link
Owner

Thank you!

@staabm staabm deleted the stan2 branch December 9, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants