more cleanup

sebastienros · Jul 13, 2024 · 5a61143 · 5a61143
1 parent 5bd6e32
commit 5a61143
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/Jint/Native/TypedArray/TypedArrayConstructor.Uint8Array.cs b/Jint/Native/TypedArray/TypedArrayConstructor.Uint8Array.cs
@@ -308,6 +308,8 @@ private JsTypedArray FromHex(JsValue thisObject, JsValue[] arguments)
         return ta;
     }
 
+    private static readonly SearchValues<char> HexAlphabet = SearchValues.Create("0123456789abcdefABCDEF");
+
     internal static FromEncodingResult FromHex(Engine engine, string s, uint maxLength = int.MaxValue)
     {
         var length = s.Length;
@@ -319,20 +321,19 @@ internal static FromEncodingResult FromHex(Engine engine, string s, uint maxLeng
             return new FromEncodingResult(bytes, ExceptionHelper.CreateSyntaxError(engine.Realm, "Invalid hex string"), read);
         }
 
-        int byteIndex = 0;
-        const string Allowed = "0123456789abcdefABCDEF";
+        var byteIndex = 0;
         while (read < length && byteIndex < maxLength)
         {
             var hexits = s.AsSpan(read, 2);
-            if (!Allowed.Contains(hexits[0]) || !Allowed.Contains(hexits[1]))
+            if (!HexAlphabet.Contains(hexits[0]) || !HexAlphabet.Contains(hexits[1]))
             {
                 return new FromEncodingResult(bytes, ExceptionHelper.CreateSyntaxError(engine.Realm, "Invalid hex value"), read);
             }
 
 #if SUPPORTS_SPAN_PARSE
             var b = byte.Parse(hexits, NumberStyles.HexNumber, CultureInfo.InvariantCulture);
 #else
-                var b = byte.Parse(hexits.ToString(), NumberStyles.HexNumber, CultureInfo.InvariantCulture);
+            var b = byte.Parse(hexits.ToString(), NumberStyles.HexNumber, CultureInfo.InvariantCulture);
 #endif
             bytes[byteIndex++] = b;
             read += 2;