The toString() of 'class' and 'function' return SourceText #1620
Conversation
scgm0
changed the title
scgm0
changed the title
|
@lahma What do you think? I'm not familiar with c# and jint.... |
|
Well I think that this PR is missing a description about what is trying to be achieved and why. Also there's no test case(s) for changes that would show how things are improved. Tests are also failing. |
Implement the target: |
The Tests should be fine now, on my computer only some of the Date tests failed, this should just be a problem with my computer settings. |
|
@lahma Found out that the SourceText returned by Esprima is currently missing Comments, which isn't perfect, but I think it's still a bit better than just returning native code. |
|
There are many failing tests: https://github.com/sebastienros/jint/actions/runs/5948466549?pr=1620 , also no new test case to show what was fixed. |
The tests that failed were all Function/prototype/toString related in Test262, because the SourceText returned by Esprima currently does not contain Comments, and the tests in Test262 require the SourceText returned by toString to contain Comments. |
|
@lahma Trying to pass the test requires Esprima to update the relevant content, is it possible to merge pr first and wait for Esprima to update? |
|
Are you working on updating esprima somehow? |
I'm sorry to say that I tried, but it's beyond my current capabilities( |
Probably not the best, I just don't know how to describe it in the issue(
Edit:
I noticed that the previous reason for returning native code was that Esprima didn't support it (in the ToString comment for FunctionInstance), but I found that Esprima now supports returning SourceText, so wanted to align with the behaviour of the mainstream js engines.