Optimize URI decode and encode #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dispatch via custom error signaling to remove costly throws * minimize allocations
lahma
force-pushed
the
optimize-encode-decode
branch
from
6db1547
to
1996b32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slows down test suite running a lot as suite goes trough each invalid character causing exceptions handling the program flow.
Running 262 suite in release mode from from console (
dotnet test -c Release).Old:
Passed! - Failed: 0, Passed: 56283, Skipped: 11595, Total: 67878, Duration: 31 s - Jint.Tests.Test262.dll (net6.0)New:
Passed! - Failed: 0, Passed: 56283, Skipped: 11595, Total: 67878, Duration: 25 s - Jint.Tests.Test262.dll (net6.0)