-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic cubemap support. #240
Conversation
Hmm... WASM support might be tricky -- I'm having difficulty getting the example WASM project to compile... |
Ran a quick profiling test on the cube_map.rs example to try and figure out what the startup time was coming from. Apparently, the PNG decoder is pretty slow (according to my profiling results 96% of the startup time is spent in the png decode function). Probably not worth digging into at the moment. I just noticed that a lot of time was being spent in the Anyway, it goes beyond the scope of this PR and the only short-term modification I can think of making is multithreading the cubemap loading function which is probably more trouble than it's worth. |
@sebcrozet some quick questions for you when you get a chance:
Sorry for the big PR -- this ended up unfurling into more changes than I was expecting. When I convert it from a draft PR, I can create a few stacked PRs for more sane chunks of work (i.e. make |
WASM support through The recent work #241 is about moving away from |
Some comments:
I realize this PR is very old, but I would be willing to pick it up and make these modifications if there is interest (i.e. someone wants to review). |
While working on a game prototype using kiss3d, I realized one thing that was missing in the base library was cubemap/skybox support. I think adding support for this is generally useful for 3D prototyping, and if it's possible with a one liner, all the better.
Still TODO: