Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/n+1 queries #3

Merged
merged 8 commits into from
Dec 13, 2021
Merged

Feature/n+1 queries #3

merged 8 commits into from
Dec 13, 2021

Conversation

sebi-golfgenius
Copy link
Owner

@sebi-golfgenius sebi-golfgenius commented Dec 13, 2021

Fixes: #5

Changes

Added eagerly loading in scores controller, method user_feed. Lazy loading was making new queries to get the user for every score from feed (same user for every score).

Before
n+1_before

After
n+1_after

@AACraiu
Copy link

AACraiu commented Dec 13, 2021

@sebi-golfgenius add reference to the solved issue in the PR description

@sebi-golfgenius sebi-golfgenius merged commit 072ae55 into develop Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants