Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Upgrade to bazel 8.1.0 #470

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[Build] Upgrade to bazel 8.1.0 #470

wants to merge 2 commits into from

Conversation

tongke6
Copy link
Collaborator

@tongke6 tongke6 commented Feb 19, 2025

No description provided.

@tongke6 tongke6 requested review from shaojian-ant, w-gc, FollyCoolly and a team February 19, 2025 07:49
@tongke6 tongke6 marked this pull request as ready for review February 19, 2025 07:50
@tongke6 tongke6 marked this pull request as draft February 19, 2025 08:33
@anakinxc
Copy link
Collaborator

Consider projects like xla are still using bazel 6, this feels like a little bit too aggressive.

@tongke6
Copy link
Collaborator Author

tongke6 commented Feb 19, 2025

Consider projects like xla are still using bazel 6, this feels like a little bit too aggressive.

Yes, I made some attempts, but many dependencies are still incompatible with bazel 8. As a result, this effort has been put on hold for now. We will consider restarting it when the conditions are more favorable.

@Jamie-Cui
Copy link
Collaborator

LGTM, though it would be better it we have cmake support. :)

Copy link
Collaborator

@Jamie-Cui Jamie-Cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants