Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Compose FF to have vectors of FlowFunctionPtrType #710

Merged
merged 6 commits into from
Apr 7, 2024

Conversation

MMory
Copy link
Member

@MMory MMory commented Mar 11, 2024

... which is necessary, since FlowFunctionTy is a virtual interface

…sary, since FlowFunctionTy is a virtual interface
@MMory MMory requested a review from fabianbs96 as a code owner March 11, 2024 21:27
@MMory MMory requested review from fabianbs96 and removed request for fabianbs96 March 11, 2024 21:27
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
MMory and others added 3 commits March 12, 2024 17:57
Co-authored-by: Fabian Schiebel <[email protected]>
Co-authored-by: Fabian Schiebel <[email protected]>
Copy link
Member

@fabianbs96 fabianbs96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Maybe, we should also add a compose function to FlowFunctionTemplates, since Compose is deprecated.

@fabianbs96 fabianbs96 merged commit e02d90c into development Apr 7, 2024
5 checks passed
@fabianbs96 fabianbs96 deleted the f-FixComposeFFPtrTy branch April 7, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants