Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversion overflow false positive when using ParseUint #1192

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

ben-krieger
Copy link
Contributor

Extends the check for ParseInt (with proper bit size) to ParseUint.

Two tests were added.

  1. To check that ParseUint does not cause a false positive
  2. To check that ParseInt causes a true positive when casting to unsigned

@ccojocar ccojocar merged commit 4ae73c8 into securego:master Aug 28, 2024
6 checks passed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.35%. Comparing base (c52dc0e) to head (7029667).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1192   +/-   ##
=======================================
  Coverage   67.34%   67.35%           
=======================================
  Files          74       74           
  Lines        4045     4046    +1     
=======================================
+ Hits         2724     2725    +1     
  Misses       1195     1195           
  Partials      126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants