Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Money market interface #161

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Money market interface #161

merged 5 commits into from
Aug 23, 2024

Conversation

SissonJ
Copy link
Collaborator

@SissonJ SissonJ commented Aug 21, 2024

No description provided.

Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: 95444a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@shadeprotocol/shadejs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

totalPages: number,
totalItems: number,
data: {
[token: string]: T
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this type should be modified or renamed more specifically for the use case, because I know that there are going to be other types of pagination data in the pipeline (swap configs for example) that won't be keyed by a token.

@@ -0,0 +1,5 @@
---
"@shadeprotocol/shadejs": minor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to patch since we aren't releasing any new feature to the public

lcdEndpoint,
chainId,
moneyMarketContracts,
batchSize = SERVICE_BATCH_SIZE.PAIR_INFO,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would just leave this empty for now so we don't accidentally forget about this and leave pair_info in as the default.

lcdEndpoint,
chainId,
moneyMarketContracts,
batchSize = SERVICE_BATCH_SIZE.PAIR_INFO,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

lcdEndpoint,
chainId,
moneyMarketContracts,
batchSize = SERVICE_BATCH_SIZE.PAIR_INFO,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

Copy link
Collaborator

@AustinWoetzel AustinWoetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done! Only a few minors.

@AustinWoetzel AustinWoetzel merged commit fae6c9c into develop Aug 23, 2024
4 checks passed
@AustinWoetzel AustinWoetzel deleted the money-market-interface branch August 23, 2024 20:37
AustinWoetzel added a commit that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants