Skip to content

Add insecure features #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add insecure features #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
package main

import (
"fmt"
"log"
"math/rand"
"net/http"

"github.com/gin-gonic/gin"
Expand All @@ -19,6 +21,9 @@ func (Tweet) TableName() string {
}

func main() {
r := rand.Int()
Copy link

@github-actions github-actions bot Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reported by reviewdog 🐶
Do not use math/rand. Use crypto/rand instead.

fmt.Printf("Hello: %d\n", r)

db, err := gorm.Open(sqlite.Open("sample.db"), &gorm.Config{})
if err != nil {
log.Fatalf("failed to open a database: %s", err.Error())
Expand All @@ -33,6 +38,15 @@ func main() {
"posts": posts,
})
})
r.GET("/search", func(c *gin.Context) {
title, _ := c.GetQuery("title")
query := fmt.Sprintf("select * from posts where title LIKE '%%%s%%'", title)
Copy link

@github-actions github-actions bot Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reported by reviewdog 🐶
A raw query is used: "select * from posts where title LIKE '%%%s%%'".

posts := []Tweet{}
db.Raw(query).Scan(&posts)
c.JSON(http.StatusOK, map[string]interface{}{
"posts": posts,
})
})
r.POST("/post", func(c *gin.Context) {
title := c.PostForm("title")
db.Create(&Tweet{
Expand Down