Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to pass graphviz output format #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sbrugman
Copy link

PDF is much crisper

Tested locally with:

impulse drawgraph --format pdf [my_package]

png:

pdf:

@seddonym
Copy link
Owner

Thanks for this, nice idea!

My concern with this is that I have been wondering about moving away from Graphviz as a dependency. By adding this to the API we are committing to supporting other file formats.

I'm going to leave this one open for the time being, until I've got a good understanding of whether there are any alternatives to Graphviz.

@sbrugman
Copy link
Author

To make it more generic you could consider forwarding unknown options to the graph save/build methods: https://click.palletsprojects.com/en/5.x/advanced/#forwarding-unknown-options

This way there is no tight link with graphviz, but still there is the ability for passing arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants