Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not init facade in adapter #47

Merged
merged 9 commits into from
Oct 6, 2023
Merged

Do not init facade in adapter #47

merged 9 commits into from
Oct 6, 2023

Commits on Oct 6, 2023

  1. Add empty collections folder to tests

    @henhuy
    henhuy committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    f5043b4 View commit details
    Browse the repository at this point in the history

  2. Refactor Adapter to not init facade

    @henhuy
    henhuy committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    6e07bf2 View commit details
    Browse the repository at this point in the history

  3. Update lock file [data-adapter]

    @nailend @henhuy
    nailend authored and henhuy committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    4ea35fe View commit details
    Browse the repository at this point in the history

  4. Update PROCESS_TYPE_MAP.yaml 

    No data_adapter test since it should be tested in data_adapter itself
    @FelixMau @henhuy
    FelixMau authored and henhuy committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    aada73e View commit details
    Browse the repository at this point in the history

  5. Dataclass dependencies 

    To create a Mapper instance a adapter is neccessary but to create an adapter instance a mapper is neccessary as well. Therefore a new function has been created in Mapper to do the job the adapter instance did before (giving out all names and types of occouring fields)
    @FelixMau @henhuy
    FelixMau authored and henhuy committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    408e419 View commit details
    Browse the repository at this point in the history

  6. Fix test mapping with sequence

    @henhuy
    henhuy committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    23e1c3c View commit details
    Browse the repository at this point in the history

  7. Minor naming change

    @henhuy
    henhuy committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    49971f3 View commit details
    Browse the repository at this point in the history

  8. Minor change

    @henhuy
    henhuy committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    f28a453 View commit details
    Browse the repository at this point in the history

  9. Add region and year to extra fields and remove additional attributes

    @henhuy
    henhuy committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    e539037 View commit details
    Browse the repository at this point in the history