Fix crackle serve, use seekJobs theme for braid-site fixture, o…

…nly render loader during dev (#213)
seek-oss · Nov 6, 2024 · f8cfe89 · f8cfe89
1 parent 80213ba
commit f8cfe89
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 4 deletions.
diff --git a/.changeset/nice-sheep-search.md b/.changeset/nice-sheep-search.md
@@ -0,0 +1,5 @@
+---
+'@crackle/cli': patch
+---
+
+Fix error when running `crackle serve`
diff --git a/.changeset/polite-pandas-raise.md b/.changeset/polite-pandas-raise.md
@@ -0,0 +1,5 @@
+---
+'@crackle/core': patch
+---
+
+Only render loader during development
diff --git a/fixtures/braid-site/src/App.tsx b/fixtures/braid-site/src/App.tsx
@@ -9,10 +9,10 @@ import {
   Heading,
   Stack,
 } from 'braid-design-system';
-import apac from 'braid-design-system/themes/apac';
+import seekJobs from 'braid-design-system/themes/seekJobs';
 
 const App: AppShell = ({ children }) => (
-  <BraidProvider theme={apac}>
+  <BraidProvider theme={seekJobs}>
     <Stack space="medium">
       <Card tone="promote">
         <ContentBlock>

diff --git a/packages/cli/src/index.ts b/packages/cli/src/index.ts
@@ -64,6 +64,7 @@ yargs(process.argv.slice(2))
     handler: async (overrides) => {
       let server: CrackleServer | null = null;
 
+      const { serve } = await import('@crackle/core/serve');
       let config = await resolveConfig({
         onUpdate: async (newConfig) => {
           config = mergeConfig(newConfig, { web: withoutYargs(overrides) });
@@ -78,7 +79,6 @@ yargs(process.argv.slice(2))
       });
       config = mergeConfig(config, { web: withoutYargs(overrides) });
 
-      const { serve } = await import('@crackle/core/serve');
       server = await serve(config);
     },
   } satisfies CommandModule<unknown, UserConfig['web']>)

diff --git a/packages/core/entries/render/shared.tsx b/packages/core/entries/render/shared.tsx
@@ -36,7 +36,7 @@ export const Page = ({
       <head>{headTags}</head>
       <body>
         {criticalCssPlaceholder ?? null}
-        <LoadingIcon />
+        {import.meta.env.DEV && <LoadingIcon />}
         <div id="app">
           <StaticRouter location={path}>
             <AppShell routeMetadata={metadata}>{children}</AppShell>

diff --git a/packages/core/src/vite-env.d.ts b/packages/core/src/vite-env.d.ts
@@ -0,0 +1,2 @@
+// eslint-disable-next-line spaced-comment
+/// <reference types="vite/client" />
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		// eslint-disable-next-line spaced-comment
		/// <reference types="vite/client" />