Vitest migration #1232
Open
Vitest migration #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a12e61d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
williamlark
approved these changes
Apr 16, 2025
| - name: Test | ||
| run: aa-exec --profile=chrome pnpm run test && aa-exec --profile=chrome pnpm run test:sku-init | ||
| run: aa-exec --profile=chrome pnpm run test |
There was a problem hiding this comment.
Does vitest have a cache we should persist?
There was a problem hiding this comment.
I checked all around and there isn't any. There are some plugins that maintain a cache but they have very low usage and stars so I don't want to tie this to that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outline:
skuhas moved toesmand is starting experimentalvitesupport. This means thatvitestmakes more sense for the test suite. It allows us to test everything asesmprojects and it speeds up our internal test suite.jesthas also not seen a major update since29.7and still only has experimentalesmsupport.This change also helps us understand how to migrate
skuprojects over tovitestif they are using thesku testcommand.Changes:
vitest.fixture/jest-test. This test now uses thebin/jest.jsfile to run the tests.portandstrict-portas arguments forserve|startcommands.