Modified mentee registration validations #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjula-sack
reviewed
Oct 2, 2024
src/schemas.ts
Outdated
| contactNo: z | ||
| .string() | ||
| .min(1, { message: 'Contact number cannot be empty' }) | ||
| .regex(/^\+[1-9]\d{1,14}$/, 'Invalid contact number'), |
There was a problem hiding this comment.
@Disura-Randunu Did you check this for multiple countries? Each country has different lengths.
There was a problem hiding this comment.
Thats why a common length was added. Around 14 digits. Should start with + to indicate the country code
There was a problem hiding this comment.
We probably need to say that you need to add + then let's remove + validations
There was a problem hiding this comment.
/^+[1-9]\d{1,3}\d{6,12}$/
this is a bit more correct than before. can have upto 3 numbers after + which makes the country code. then 6-12 digits which is kind of standard amount of numbers in any country.
There was a problem hiding this comment.
@anjula-sack updated contactNo validation
anjula-sack
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix #128
Goals
Improve validations on Mentee registration.
Approach
Modified Mentee Application Validation Schema to handle possible invalids for several fields (contact no, graduated year, year of study. cv link)
Screenshots
Checklist
Related PRs
Test environment
Learning