Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making 'Become a Mentor' form to validate number as input value #196 #202

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

shiv-0101
Copy link
Contributor

Purpose

The contact number field was not validating input properly. It was accepting strings or any unfair input, allowing the user to go to the next step without proper validation.

The purpose of this PR is to fix #196

Goals

Goal was to change 'text' to 'number'

Approach

Updated the input text value from 'text' to 'number' so that only number can be passed and user can move to next step.

Checklist

  • [✅] This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • [✅ ] I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • [✅ ] My code follows the style guidelines of this project
  • [✅] I have performed a self-review of my own code
  • [✅ ] I have commented my code, particularly in hard-to-understand areas
  • [✅ ] I have made corresponding changes to the documentation

Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @shiv-0101

@anjula-sack anjula-sack merged commit 021ab78 into sef-global:development Oct 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact number field validation required on "Become a Mentor" form
2 participants