Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ScholarX logo size in tablet view [fixes #205] #207

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

Kinshu-Learner
Copy link
Contributor

@Kinshu-Learner Kinshu-Learner commented Oct 10, 2024

Purpose

The purpose of this PR is to fix #205

Goals

Reduced the font sizes of nav items slightly, along with some paddings and margins in tablet view so as to make space for the ScholarX logo to fit completely.

Screenshots

image

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @Kinshu-Learner

@anjula-sack anjula-sack merged commit 05b7b53 into sef-global:development Oct 15, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the ScholarX logo in the mobile view
3 participants