Skip to content

Commit

Permalink
Fix a systemd dependency ("network-online.target")
Browse files Browse the repository at this point in the history
- Fix a problem that the xrdp.service fail to auto-start when instructed to listen on a specific interface
- By changing the "network.target" systemd dependency to "network-online.target"
- The "network-online.target", in short, means at least one network interface has finished IP level setup.
- The previously used "network.target" is vague and does not provide such guarantee (ref: man systemd.special(7)).
- Which often cause "xrdp.service" fail to auto-start when the service is configured to listen on a specific interface (e.g. in xrdp.ini, "port=tcp://192.168.0.1:3389"). Because the interface may have not finish setting up its IP, when "xrdp.service" starts.
  • Loading branch information
schen0x committed May 22, 2024
1 parent 640411d commit 21e11de
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion instfiles/xrdp.service.in
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Description=xrdp daemon
Documentation=man:xrdp(8) man:xrdp.ini(5)
Requires=xrdp-sesman.service
After=network.target xrdp-sesman.service
After=network-online.target xrdp-sesman.service

[Service]
Type=exec
Expand Down

0 comments on commit 21e11de

Please sign in to comment.