Add support for proxies #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supported proxies are: HTTP and SOCKS5. SOCKS4 proxies aren't supported because OkHttp doesn't support them because Android has issues with SOCKS4. All http requests now made through OkHttp. All OkHttp instances now share same thread pool.
Closed
|
cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supported proxies are: HTTP and SOCKS5.
SOCKS4 proxies aren't supported because OkHttp doesn't support them because Android has issues with SOCKS4.
All http requests now made through OkHttp.
All OkHttp instances now share same thread pool.
I have tested this with public proxies and with Orbot. Orbot has issues with http proxy but SOCKS works. I haven't tested proxy auth but it should work according to OkHttp documentation.