New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SFMC] Remove stats for SFMC #2647

Open

harsh-joshi99 wants to merge 1 commit into main from sfmc/stats-cleaup

Contributor

harsh-joshi99 commented Dec 13, 2024

Remove the stats code for SFMC since we have completed the investigation regarding uniqueness of key and id of events in payload.

We are only seeing 1 key/id per payload hence all events in a payload have similar key/id according to the stats.

Testing

Testing is not required since we are removing code only added for checking stats.

Added unit tests for new functionality - NR
Tested end-to-end using the local server - NR
[If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change. - NR
[Segmenters] Tested in the staging environment - NR
[Segmenters] [If applicable for this change] Tested for regression with Hadron. - NR


          remove stats for sfmc

68313ab

harsh-joshi99 requested a review from a team as a code owner

December 13, 2024 05:49

github-actions bot added mode:cloud team:segment labels

joe-ayoub-segment added the not-partner-eng-review (cloud) label

varadarajan-tw approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mode:cloud not-partner-eng-review (cloud) team:segment