Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding oauth2.0 to First Party DV360 #2733

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Adding oauth2.0 to First Party DV360 #2733

wants to merge 4 commits into from

Conversation

rvadera12
Copy link
Contributor

@rvadera12 rvadera12 commented Feb 10, 2025

This PR updates the first party dv360 destination authentication to an oauth2.0 flow.

Testing

TestDoc

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.46%. Comparing base (52537f3) to head (6c842fa).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
...ctions/src/destinations/first-party-dv360/index.ts 66.66% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2733   +/-   ##
=======================================
  Coverage   78.46%   78.46%           
=======================================
  Files        1036     1036           
  Lines       18771    18797   +26     
  Branches     3561     3579   +18     
=======================================
+ Hits        14729    14750   +21     
+ Misses       2844     2841    -3     
- Partials     1198     1206    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rvadera12 rvadera12 changed the title adding oauth to fpdv360 Adding oauth2.0 to First Party DV360 Feb 14, 2025
@rvadera12 rvadera12 marked this pull request as ready for review February 14, 2025 06:18
@rvadera12 rvadera12 requested a review from a team as a code owner February 14, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant