feat: Allow for more granular tracked lifecycle events to track #385
+155
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't merge this as it breaks the API. The optimal way to do this is disable lifecycle events, and track on the ones you do, either in your code or via a plugin similar to the lifecycle plugin in this codebase. |
|
@bsneed I made sure the API wasn't broken when implementing this, would you mind explaining a bit more? I don't mind refactoring it... |
|
@delannoyk you totally did! I'm so sorry I missed that. I shoulda dug deeper, so thanks for inquiring about it. I'll reopen this and give it a whirl in just a bit. |
|
@bsneed appreciate it, but also no pressure! I was just wondering. Thanks for considering it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Segment team 👋🏻,
We found ourselves not wanting to track all the lifecycle events in our app. As far as I can tell there was no way to filter them so I implemented this as an OptionSet instead of a boolean value.
Let me know if this is acceptable and/or if you have any questions or suggestions.
Thanks.
Kevin