Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support json type and array type #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add support json type and array type #21

wants to merge 1 commit into from

Conversation

arturoeanton
Copy link

add support json type and array type

@tejasmanohar
Copy link
Contributor

Thanks for the PR, but it needs tests to be merged. It should be fairly easy to extend the existing test case using #19 (which has merge conflicts now) as a template

@eatonphil
Copy link

Arrays are not formatted as json. For example, the raw value of a ARRAY column for me is [bash]. I have a short-term fix for this (since it appears the real problem is in Athena itself) in #30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants