This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Add support for writing Go int16 type #505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for writing int16 values. (Currently trying to write a Go struct with int16 values causes the error
panic: cannot convert Go values of type int16 to parquet value.)I based the
writeRowsFuncOfInt16function on the existingwriteRowsFuncOfTimeand tried to add test cases wherever they seemed appropriate.The "int16" scenario in
writer_test.gois comparing against output from my locally built version of parquet-tools, and I noticed that it's creating slightly different output for some of the other scenarios, so it may need to be changed to pass the official build process.