This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default Spark writes parquet files with int96 timestamps, even though the type has been deprecated for a while. There are details of the format and some discussion here:
apache/parquet-format#49
This PR adds support for reading int96 values into timestamps. (Just reading, not writing.)
During implementation I found that the
convertToType()
function inconvert.go
was converting in the wrong direction. I've added a test scenario "string to int" inconvert_test.go
which fails with the existing code and succeeds with the updated version.Also, converting types with null values failed in some situations, so I added null checks to the
ConvertValue
functions intype.go
and added the "nils" scenario inconvert_test.go
.