Adding OneSignal Partner Source Documentation #5499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcgilbert
requested changes
Oct 9, 2023
| @@ -0,0 +1,83 @@ | |||
| ## OneSignal Source | |||
There was a problem hiding this comment.
Suggested change
| ## OneSignal Source | |
| --- | |
| title: OneSignal Source | |
| id: o9OyD6xsVJ | |
| beta: true | |
| --- |
joe-ayoub-segment
requested changes
Oct 9, 2023
|
|
||
| 1. From your workspace’s [Sources catalog page](https://app.segment.com/goto-my-workspace/sources/catalog) click on “Add Source”. | ||
| 2. Search for “OneSignal” within the Sources Catalog and confirm by clicking “Add Source” | ||
| 3. Give the source a nickname and a schema name. The nickname is a label used in the Segment interface, and the schema name is the namespace you query against in your warehouse. Both can be anything you like, but we recommend sticking to something that reflects the source itself and distinguishes amongst your environments (for example, OneSignal_Prod, OneSignal_Staging). Click add source to save your settings. |
There was a problem hiding this comment.
Suggested change
| 3. Give the source a nickname and a schema name. The nickname is a label used in the Segment interface, and the schema name is the namespace you query against in your warehouse. Both can be anything you like, but we recommend sticking to something that reflects the source itself and distinguishes amongst your environments (for example, OneSignal_Prod, OneSignal_Staging). Click add source to save your settings. | |
| 3. Give the source a name, for example OneSignal_Prod. The name is used in the Segment interface. Click add source to save your settings. |
joe-ayoub-segment
requested changes
Oct 9, 2023
brayden-onesignal
force-pushed
the
onesignal-source-docs
branch
from
7f6eba2 to
f004d6f
Compare
|
@tcgilbert @joe-ayoub-segment @fhboswell Addressed the feedback! |
|
looks good to me. @pwseg can we get this pushed through today? |
|
Hey @tcgilbert can we merge this on cycle tomorrow? |
fhboswell
requested review from
joe-ayoub-segment,
tcgilbert and
brayden-onesignal
|
I created #5552 to deploy these docs. They'll go out today, 18 October 2023. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adding OneSignal Partner Source Documentation
Merge timing
ASAP once approved - By Oct 10th 2023